Flagsmith / Flagsmith/flagsmith-sql-flag-engine
Semver: handle prerelease comparison
- 主要言語
- Python
- スター
- 1
- フォーク
- 0
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
`semver_sort_key` (in `translator._semver_sort_key_expr`) extracts the first three digit-runs from the version string, zero-pads each to 10 chars, and joins with dots. This gives correct major.minor.patch ordering but ignores prerelease: `1.2.3-beta` and `1.2.3` produce the same key.
Per [semver spec](https://semver.org/#spec-item-11), `1.2.3-beta < 1.2.3` (prerelease versions compare *less than* the corresponding release). My current implementation gets this wrong.
## What to ship
Extend the sort key with a prerelease tail. Approximation that's good enough for behavioural-targeting use:
- Extract everything after `-` (and before any `+` build metadata) as the prerelease string.
- Append a sentinel: `'~'` for absent prerelease (sorts after any prerelease alphabetically — `~` is high-ASCII), the literal prerelease string otherwise.
- Per-dot-segment numeric prerelease comparison is a further refinement (engine semver lib does this); skip for v1.
## Why deferred
Smoke-tested at 23/24 parity in the PoC; the one mismatch was the prerelease case described above. Customer segments using semver tend to use clean major.minor.patch (`app_version: "2.5.10"`) without prerelease tails. Will revisit if a customer reports an unexpected match for a `-beta` version.
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
Start at translator._semver_sort_key_expr and inspect the existing semver_sort_key behavior and its callers. Verify that versions such as 1.2.3-beta sort before 1.2.3, while build metadata does not affect the prerelease portion; done means the documented mismatch is corrected without requiring numeric prerelease-segment comparison.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python, sql
- 領域
- databases
- issue の種類
- バグ
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 静か
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 74/100