Flagsmith / Flagsmith/flagsmith-sql-flag-engine
Semver: handle prerelease comparison
- 主要语言
- Python
- 星标
- 1
- 派生
- 0
- PR 合并指标
- 30 天内没有已合并 PR
描述
`semver_sort_key` (in `translator._semver_sort_key_expr`) extracts the first three digit-runs from the version string, zero-pads each to 10 chars, and joins with dots. This gives correct major.minor.patch ordering but ignores prerelease: `1.2.3-beta` and `1.2.3` produce the same key.
Per [semver spec](https://semver.org/#spec-item-11), `1.2.3-beta < 1.2.3` (prerelease versions compare *less than* the corresponding release). My current implementation gets this wrong.
## What to ship
Extend the sort key with a prerelease tail. Approximation that's good enough for behavioural-targeting use:
- Extract everything after `-` (and before any `+` build metadata) as the prerelease string.
- Append a sentinel: `'~'` for absent prerelease (sorts after any prerelease alphabetically — `~` is high-ASCII), the literal prerelease string otherwise.
- Per-dot-segment numeric prerelease comparison is a further refinement (engine semver lib does this); skip for v1.
## Why deferred
Smoke-tested at 23/24 parity in the PoC; the one mismatch was the prerelease case described above. Customer segments using semver tend to use clean major.minor.patch (`app_version: "2.5.10"`) without prerelease tails. Will revisit if a customer reports an unexpected match for a `-beta` version.
贡献指南
这个仓库没有索引到贡献指南
调研方向
从 translator._semver_sort_key_expr 开始,检查现有的 semver_sort_key 行为及其调用方。验证 1.2.3-beta 等版本会排在 1.2.3 之前,同时构建元数据不会影响 prerelease 部分;完成意味着已修正文档所述的不一致,且不要求对 prerelease 段进行数值比较。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python, sql
- 领域
- databases
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 冷清
- 描述清晰度
- 描述清楚
- 新手友好度
- 74/100