FirebaseExtended / FirebaseExtended/reactfire
Usage of useUser with useFirestoreDocData not very compatible within custom hooks
- 主要言語
- TypeScript
- スター
- 3.6k
- フォーク
- 403
- 平均マージ
- 14時間 53分
- マージ済み PR(30日)
- 5
説明
### Version info
**React:** 18 experimental
**Firebase:** 9
**ReactFire:** 4
**Other (e.g. Node, browser, operating system) (if applicable):**
### Test case
### Steps to reproduce
```
const useMyHook= () => {
const firestore = useFirestore();
const {data: user} = useUser();
const ref = user && doc(firestore, "users", user.uid);
const {data: userData} = useFirestoreDocData(ref);
return userData;
}
```
### Behavior
Since useUser is returning the type `User | null` , we need to check, if the user is available. But in the case when the user is null, useFirestoreDocData cannot be called, since the ref would not exist. In react we are not allowed to write:
` const {data: userData} = ref && useFirestoreDocData(ref) `
One way to get around this issue is by passing in the user as a prop, but it does not seem to be convenient, if one wants to use this hook within another hook. We would just push the issue upwards until we reach a component that is again wrapped by a component that knows if the user exists:
- component that checks if user exists (like deprecated AuthCheck)
- component that is rendered when user exists
- hook that is called within that component
Another alternative for typescript is writing `user!` with exclamation mark, but this does not feel proper.
I hope the case is clear and you might know a better way to deal with it.
I think with react-fire v3 (fb v8) I wasn't experiencing this issue. Since it was probably solved with this issue: https://github.com/FirebaseExtended/reactfire/issues/249
コントリビューションガイド
調査の方向性
Start by tracing the useUser, useFirestore, and useFirestoreDocData entry points and reproduce the null-user path with the custom hook shown in the issue. Compare the reported ReactFire v4 behavior with the ReactFire v3 behavior referenced in issue 249; the issue does not name a file, test, or concrete completion criterion.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- firebase, react, typescript
- 領域
- authentication, database, frontend
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- 説明が足りない
- 初心者へのやさしさ
- 25/100