FirebaseExtended / FirebaseExtended/reactfire

Usage of useUser with useFirestoreDocData not very compatible within custom hooks

Ouverte
#423 4 commentaires 5 réactions 0 personnes assignées Voir sur GitHub
v5
Langage dominant
TypeScript
Étoiles
3.6k
Forks
403
Merge moyen
14 h 53 min
PR mergées (30 j)
5

Description

### Version info

**React:** 18 experimental

**Firebase:** 9

**ReactFire:** 4

**Other (e.g. Node, browser, operating system) (if applicable):**

### Test case

### Steps to reproduce

```
const useMyHook= () => {

const firestore = useFirestore();
const {data: user} = useUser();
const ref = user && doc(firestore, "users", user.uid);
const {data: userData} = useFirestoreDocData(ref);

return userData;
}
```

### Behavior

Since useUser is returning the type `User | null` , we need to check, if the user is available. But in the case when the user is null, useFirestoreDocData cannot be called, since the ref would not exist. In react we are not allowed to write:
` const {data: userData} = ref && useFirestoreDocData(ref) `

One way to get around this issue is by passing in the user as a prop, but it does not seem to be convenient, if one wants to use this hook within another hook. We would just push the issue upwards until we reach a component that is again wrapped by a component that knows if the user exists:

- component that checks if user exists (like deprecated AuthCheck)
- component that is rendered when user exists
- hook that is called within that component

Another alternative for typescript is writing `user!` with exclamation mark, but this does not feel proper.

I hope the case is clear and you might know a better way to deal with it.
I think with react-fire v3 (fb v8) I wasn't experiencing this issue. Since it was probably solved with this issue: https://github.com/FirebaseExtended/reactfire/issues/249

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.