FAForever / FAForever/server

Replace ban text with localizable message

オープン
#640 コメント 18 件 リアクション 0 件 担当者 0 名 GitHub で見る
:dollar: Funded on Issuehunt requires client changes
主要言語
Python
スター
72
フォーク
84
平均マージ
5時間 11分
マージ済み PR(30日)
1

説明

[Issuehunt badges](https://issuehunt.io/r/FAForever/server/issues/640)

The server should not be sending any strings that get rendered in the client, because these strings are in English and we can't be sure that the user on the other end has their client set to English (in fact a majority of people probably knows English only as a second language, or does not know it very well at all). In fact issue #444 already covers this, but I'm making another ticket just for this message because changing it would allow us to drop the `humanize` dependency.

Here is a link to the message:
https://github.com/FAForever/server/blob/e4ca993a9b7ea8123c64f6917bf9edd05f69b0ce/server/lobbyconnection.py#L1094

It should be replaced with something like:
```
{
"command": "banned",
"expires_at":
}
```

See #183 for inspiration, but note that we should be sending ISO timestamps (in UTC) and not timedeltas.

---

IssueHunt Summary

### Backers (Total: $5.00)

- [askaholic askaholic](https://issuehunt.io/u/askaholic) ($5.00)

#### [Become a backer now!](https://issuehunt.io/r/FAForever/server/issues/640)
#### [Or submit a pull request to get the deposits!](https://issuehunt.io/r/FAForever/server/issues/640)
### Tips

- Checkout the [Issuehunt explorer](https://issuehunt.io/r/FAForever/server/) to discover more funded issues.
- Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。