FAForever / FAForever/server

Replace ban text with localizable message

Abierto
#640 18 comentarios 0 reacciones 0 asignados Ver en GitHub
:dollar: Funded on Issuehunt requires client changes
Lenguaje dominante
Python
Estrellas
72
Forks
84
Merge medio
5 h 11 min
PR fusionados (30 d)
1

Descripción

[Issuehunt badges](https://issuehunt.io/r/FAForever/server/issues/640)

The server should not be sending any strings that get rendered in the client, because these strings are in English and we can't be sure that the user on the other end has their client set to English (in fact a majority of people probably knows English only as a second language, or does not know it very well at all). In fact issue #444 already covers this, but I'm making another ticket just for this message because changing it would allow us to drop the `humanize` dependency.

Here is a link to the message:
https://github.com/FAForever/server/blob/e4ca993a9b7ea8123c64f6917bf9edd05f69b0ce/server/lobbyconnection.py#L1094

It should be replaced with something like:
```
{
"command": "banned",
"expires_at":
}
```

See #183 for inspiration, but note that we should be sending ISO timestamps (in UTC) and not timedeltas.

---

IssueHunt Summary

### Backers (Total: $5.00)

- [askaholic askaholic](https://issuehunt.io/u/askaholic) ($5.00)

#### [Become a backer now!](https://issuehunt.io/r/FAForever/server/issues/640)
#### [Or submit a pull request to get the deposits!](https://issuehunt.io/r/FAForever/server/issues/640)
### Tips

- Checkout the [Issuehunt explorer](https://issuehunt.io/r/FAForever/server/) to discover more funded issues.
- Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.