FAForever / FAForever/faf-java-api
pls improve map validation tool (upload vs server pathing)
- Ngôn ngữ chính
- Java
- Star
- 31
- Fork
- 30
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
First of all, I love our new validation tool: https://api.faforever.com/maps/validate
But I found some Issues that should be improved...
**Validate Map Name**
The map name validation for `Adaptive Map` says `adaptive_map.v0001` for the folder.
- That folder name and path is created while map upload and in `FAF Editor`
- `server created version` = `/maps/adaptive_map.v0001/adaptive_map.scmap`
**Validate scenario.lua**
But in the validation of the obviously wrong path in the scenario content, it gives you a folder path without .v0001 `/maps/adaptive_map/adaptive_map.scmap`
- As far as I know, that path is created in `GPG Editor` and needed to be applied for map upload (without .v0001 in folder and file path)? Please correct me if I'm wrong.
- `upload version` = `/maps/adaptive_map/adaptive_map.scmap`

**Conclusion**
`FAF Editor version` = `server created version` = `/maps/adaptive_map.v0001/adaptive_map.scmap`
`GPG Editor version` = `upload version` = `/maps/adaptive_map/adaptive_map.scmap`
That's why I think, the tool is confusing how it is now and leads to maps not being able to load. It would be nice to clarify if an `upload version` or an `server created version` should be validated.
It would be nice to give both options to a map maker. And validate consistently over name and scenario validation, like in picture 2#. A checkbox could be a solution to enable the map maker to get the right information. Because I really like to prevent issues like this while uploading:


**Bad example**
1# difference in validated name and scenario folder naming

**Good example**
2# example for constant folder naming with .v0001 like in the `server created version`

**One additional question**
Isn't it possible to also allow an upload with the version number in the folder?
That would be awesome. This way there is no difference between `GPG Editor` and `FAF Editor` maps and both can simply be uploaded. No broken files due to upload process ;)
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Đánh giá
Issue này chưa được đánh giá.