FAForever / FAForever/faf-java-api

pls improve map validation tool (upload vs server pathing)

Aperta
#364 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
31
Fork
30
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

First of all, I love our new validation tool: https://api.faforever.com/maps/validate
But I found some Issues that should be improved...

**Validate Map Name**
The map name validation for `Adaptive Map` says `adaptive_map.v0001` for the folder.

- That folder name and path is created while map upload and in `FAF Editor`

- `server created version` = `/maps/adaptive_map.v0001/adaptive_map.scmap`

**Validate scenario.lua**
But in the validation of the obviously wrong path in the scenario content, it gives you a folder path without .v0001 `/maps/adaptive_map/adaptive_map.scmap`

- As far as I know, that path is created in `GPG Editor` and needed to be applied for map upload (without .v0001 in folder and file path)? Please correct me if I'm wrong.

- `upload version` = `/maps/adaptive_map/adaptive_map.scmap`

![#0](https://user-images.githubusercontent.com/28671151/68895605-f002f280-0729-11ea-881b-e13728c20193.png)

**Conclusion**
`FAF Editor version` = `server created version` = `/maps/adaptive_map.v0001/adaptive_map.scmap`
`GPG Editor version` = `upload version` = `/maps/adaptive_map/adaptive_map.scmap`

That's why I think, the tool is confusing how it is now and leads to maps not being able to load. It would be nice to clarify if an `upload version` or an `server created version` should be validated.
It would be nice to give both options to a map maker. And validate consistently over name and scenario validation, like in picture 2#. A checkbox could be a solution to enable the map maker to get the right information. Because I really like to prevent issues like this while uploading:
![foldername - scenario_error](https://user-images.githubusercontent.com/28671151/68895750-3ce6c900-072a-11ea-90de-7d5c936787dc.PNG)
![foldername - script_error](https://user-images.githubusercontent.com/28671151/68895754-3f492300-072a-11ea-94e9-9dce0ce00c2b.PNG)

**Bad example**
1# difference in validated name and scenario folder naming
![#1](https://user-images.githubusercontent.com/28671151/68896158-33119580-072b-11ea-952a-07d612d924ae.png)

**Good example**
2# example for constant folder naming with .v0001 like in the `server created version`
![#2](https://user-images.githubusercontent.com/28671151/68896166-360c8600-072b-11ea-8905-bbc8f09e4c4d.png)

**One additional question**
Isn't it possible to also allow an upload with the version number in the folder?
That would be awesome. This way there is no difference between `GPG Editor` and `FAF Editor` maps and both can simply be uploaded. No broken files due to upload process ;)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.