ComputerScienceHouse / ComputerScienceHouse/gallery

Images arent always displayed in the correct orientation when viewing an image

オープン
#60 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
22
フォーク
30
平均マージ
2時間 26分
マージ済み PR(30日)
1

説明

When viewing images taken vertically (i.e. https://gallery.csh.rit.edu/view/file/36582), [some browsers](https://caniuse.com/#search=image-orientation) (i.e. new versions of firefox) correctly rotate the image based on its EXIF metadata, however, most browsers (i.e. chromium) still display it incorrectly.

in order to fix this for other browsers, there needs to be a fallback for when the `image-orientation` CSS property is not supported.

So far i've come up with:

1. Since #45 seems to be rotating thumbnails server-side, maybe we could also rotate the images server-side before displaying them, however, it seems like the `/api/files/get` endpoint is just [returning a link to s3](https://github.com/ComputerScienceHouse/gallery/blob/773b30fab2bfac69e6ac7573dc4954d0192fbcf5/gallery/__init__.py#L751), so this might be a pretty complicated way to do it.
2. alternatively, maybe we could implement the rotation using CSS classes and have the `view_file.html` template look at the metadata and decide which to use

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

Start with the view_file.html template and the /api/files/get path in gallery/__init__.py around line 751, then compare the thumbnail rotation approach discussed in issue #45. Determine how image orientation metadata can be handled for browsers without image-orientation support. Done means vertically taken images display in the correct orientation across the affected browsers.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
css, python
領域
backend, frontend
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。