ComputerScienceHouse / ComputerScienceHouse/gallery

Images arent always displayed in the correct orientation when viewing an image

Ouverte
#60 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
22
Forks
30
Merge moyen
2 h 26 min
PR mergées (30 j)
1

Description

When viewing images taken vertically (i.e. https://gallery.csh.rit.edu/view/file/36582), [some browsers](https://caniuse.com/#search=image-orientation) (i.e. new versions of firefox) correctly rotate the image based on its EXIF metadata, however, most browsers (i.e. chromium) still display it incorrectly.

in order to fix this for other browsers, there needs to be a fallback for when the `image-orientation` CSS property is not supported.

So far i've come up with:

1. Since #45 seems to be rotating thumbnails server-side, maybe we could also rotate the images server-side before displaying them, however, it seems like the `/api/files/get` endpoint is just [returning a link to s3](https://github.com/ComputerScienceHouse/gallery/blob/773b30fab2bfac69e6ac7573dc4954d0192fbcf5/gallery/__init__.py#L751), so this might be a pretty complicated way to do it.
2. alternatively, maybe we could implement the rotation using CSS classes and have the `view_file.html` template look at the metadata and decide which to use

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start with the view_file.html template and the /api/files/get path in gallery/__init__.py around line 751, then compare the thumbnail rotation approach discussed in issue #45. Determine how image orientation metadata can be handled for browsers without image-orientation support. Done means vertically taken images display in the correct orientation across the affected browsers.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
css, python
Domaine
backend, frontend
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.