CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule
Samples can't have the same asset file names across components
- Ngôn ngữ chính
- C#
- Star
- 56
- Fork
- 19
- Merge trung bình
- 40 phút
- Pull request đã merge (30 ngày)
- 1
Mô tả
### Describe the bug
_[originally discovered here](https://github.com/CommunityToolkit/Labs-Windows/pull/354#issuecomment-1487539780)_
```
"D:\a\Labs-Windows\Labs-Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj" (default target) (27:6) ->
(_HandleFileConflictsForPublish target) ->
C:\Program Files\dotnet\sdk\6.0.407\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path: D:\a\Labs-Windows\Labs-Windows\components\Shimmer\samples\Assets\Owl.jpg, D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\samples\Assets\Owl.jpg. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj]
"D:\a\Labs-Windows\Labs-Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\WinAppSdk\CommunityToolkit.App.WinAppSdk.csproj" (default target) (29:6) ->
C:\Program Files\dotnet\sdk\6.0.407\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path: D:\a\Labs-Windows\Labs-Windows\components\Shimmer\samples\Assets\Owl.jpg, D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\samples\Assets\Owl.jpg. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\WinAppSdk\CommunityToolkit.App.WinAppSdk.csproj]
```
In this case we had two components **Shimmer** and **TransitionHelper** which had a `samples\Assets\Owl.jpg` file. When the build went to include both these components it got confused.
----
We need to better identify this issue locally with an analyzer to alert a dev as an error during development (duplicate file name across repo) [easier?] or figure out how to merge resources into a cohesive collection which can still work for all the code relying on those images [hard?].
### Steps to reproduce
```text
Create two components
Setup an image with the same name in both sample directories and include in project
Try and build the all-up solution
```
### Expected behavior
Able to _either_:
- identify duplicates across components and alert developer
- use assets with the same name
### Screenshots
_No response_
### Code Platform
- [ ] UWP
- [ ] WinAppSDK / WinUI 3
- [ ] Web Assembly (WASM)
- [ ] Android
- [ ] iOS
- [ ] MacOS
- [ ] Linux / GTK
### Windows Build Number
- [ ] Windows 10 1809 (Build 17763)
- [ ] Windows 10 1903 (Build 18362)
- [ ] Windows 10 1909 (Build 18363)
- [ ] Windows 10 2004 (Build 19041)
- [ ] Windows 10 20H2 (Build 19042)
- [ ] Windows 10 21H1 (Build 19043)
- [ ] Windows 11 21H2 (Build 22000)
- [ ] Other (specify)
### Other Windows Build number
_No response_
### App minimum and target SDK version
- [ ] Windows 10, version 1809 (Build 17763)
- [ ] Windows 10, version 1903 (Build 18362)
- [ ] Windows 10, version 1909 (Build 18363)
- [ ] Windows 10, version 2004 (Build 19041)
- [ ] Other (specify)
### Other SDK version
_No response_
### Visual Studio Version
_No response_
### Visual Studio Build Number
_No response_
### Device form factor
_No response_
### Additional context
Maybe we should also think about some centralized assets that all samples have access to in case they just need an image or two to include?
### Help us help you
Yes, but only if others can assist.
Hướng dẫn đóng góp
Hướng nghiên cứu
Bắt đầu bằng cách tái hiện lỗi NETSDK1152 khi build CommunityToolkit.AllComponents.sln, tập trung vào các tệp project AllComponents Tests.WinAppSdk và WinAppSdk cùng các đường dẫn samples/Assets/Owl.jpg bị trùng lặp trong Shimmer và TransitionHelper. Xác định xem công việc nên phát hiện các tên asset bị trùng lặp hay hỗ trợ chúng trong quá trình all-up build; hoàn tất khi hành vi được chọn đã được triển khai và solution all-up không còn thất bại do các bản trùng lặp này.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- csharp
- Lĩnh vực
- build-system, tooling
- Loại issue
- Lỗi
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Cần làm rõ
- Mức phù hợp với người mới
- 25/100