CommunityToolkit / CommunityToolkit/Tooling-Windows-Submodule
Samples can't have the same asset file names across components
- Vorherrschende Sprache
- C#
- Sterne
- 55
- Forks
- 19
- Ø Merge
- 40 Min.
- Gemergte PRs (30 T.)
- 1
Beschreibung
### Describe the bug
_[originally discovered here](https://github.com/CommunityToolkit/Labs-Windows/pull/354#issuecomment-1487539780)_
```
"D:\a\Labs-Windows\Labs-Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj" (default target) (27:6) ->
(_HandleFileConflictsForPublish target) ->
C:\Program Files\dotnet\sdk\6.0.407\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path: D:\a\Labs-Windows\Labs-Windows\components\Shimmer\samples\Assets\Owl.jpg, D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\samples\Assets\Owl.jpg. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.WinAppSdk\CommunityToolkit.Tests.WinAppSdk.csproj]
"D:\a\Labs-Windows\Labs-Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\WinAppSdk\CommunityToolkit.App.WinAppSdk.csproj" (default target) (29:6) ->
C:\Program Files\dotnet\sdk\6.0.407\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path: D:\a\Labs-Windows\Labs-Windows\components\Shimmer\samples\Assets\Owl.jpg, D:\a\Labs-Windows\Labs-Windows\components\TransitionHelper\samples\Assets\Owl.jpg. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\WinAppSdk\CommunityToolkit.App.WinAppSdk.csproj]
```
In this case we had two components **Shimmer** and **TransitionHelper** which had a `samples\Assets\Owl.jpg` file. When the build went to include both these components it got confused.
----
We need to better identify this issue locally with an analyzer to alert a dev as an error during development (duplicate file name across repo) [easier?] or figure out how to merge resources into a cohesive collection which can still work for all the code relying on those images [hard?].
### Steps to reproduce
```text
Create two components
Setup an image with the same name in both sample directories and include in project
Try and build the all-up solution
```
### Expected behavior
Able to _either_:
- identify duplicates across components and alert developer
- use assets with the same name
### Screenshots
_No response_
### Code Platform
- [ ] UWP
- [ ] WinAppSDK / WinUI 3
- [ ] Web Assembly (WASM)
- [ ] Android
- [ ] iOS
- [ ] MacOS
- [ ] Linux / GTK
### Windows Build Number
- [ ] Windows 10 1809 (Build 17763)
- [ ] Windows 10 1903 (Build 18362)
- [ ] Windows 10 1909 (Build 18363)
- [ ] Windows 10 2004 (Build 19041)
- [ ] Windows 10 20H2 (Build 19042)
- [ ] Windows 10 21H1 (Build 19043)
- [ ] Windows 11 21H2 (Build 22000)
- [ ] Other (specify)
### Other Windows Build number
_No response_
### App minimum and target SDK version
- [ ] Windows 10, version 1809 (Build 17763)
- [ ] Windows 10, version 1903 (Build 18362)
- [ ] Windows 10, version 1909 (Build 18363)
- [ ] Windows 10, version 2004 (Build 19041)
- [ ] Other (specify)
### Other SDK version
_No response_
### Visual Studio Version
_No response_
### Visual Studio Build Number
_No response_
### Device form factor
_No response_
### Additional context
Maybe we should also think about some centralized assets that all samples have access to in case they just need an image or two to include?
### Help us help you
Yes, but only if others can assist.
Beitragsleitfaden
Rechercherichtung
Start by reproducing the NETSDK1152 failure when building CommunityToolkit.AllComponents.sln, focusing on the AllComponents Tests.WinAppSdk and WinAppSdk project files and the duplicate samples/Assets/Owl.jpg paths in Shimmer and TransitionHelper. Determine whether the work should detect duplicate asset names or support them during the all-up build; done means the chosen behavior is implemented and the all-up solution no longer fails on these duplicates.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- csharp
- Bereich
- build-system, tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 25/100