Codeception / Codeception/module-webdriver

`click()` doesn't find `<summary>`, `<label>`, or elements inside `<a>`

Aperta
#18 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
PHP
Stelle
39
Fork
25
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The HTML5 element `` is missing from the list of clickable elements at [`WebDriver::_findClickable()`](https://github.com/Codeception/module-webdriver/blob/master/src/Codeception/Module/WebDriver.php#L1047)

I tried to add it there just like the others: `".//summary[normalize-space(.)=$locator]",` - but this doesn't really fix it, since there are many elements allowed inside ``: https://html.spec.whatwg.org/#the-summary-element

I think this needs to be refactored, since (from looking at the code) elements inside `` are also not matched, e.g. `

...
` - which is valid HTML 5: https://html.spec.whatwg.org/#the-a-element

So I guess the arguments that are thrown into `Locator::combine()` need to be replaced by functions to allow more complex matching logic.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.