Codeception / Codeception/module-webdriver

`click()` doesn't find `<summary>`, `<label>`, or elements inside `<a>`

Abierto
#18 4 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
PHP
Estrellas
39
Forks
25
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The HTML5 element `` is missing from the list of clickable elements at [`WebDriver::_findClickable()`](https://github.com/Codeception/module-webdriver/blob/master/src/Codeception/Module/WebDriver.php#L1047)

I tried to add it there just like the others: `".//summary[normalize-space(.)=$locator]",` - but this doesn't really fix it, since there are many elements allowed inside ``: https://html.spec.whatwg.org/#the-summary-element

I think this needs to be refactored, since (from looking at the code) elements inside `` are also not matched, e.g. `

...
` - which is valid HTML 5: https://html.spec.whatwg.org/#the-a-element

So I guess the arguments that are thrown into `Locator::combine()` need to be replaced by functions to allow more complex matching logic.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.