Codeception / Codeception/module-webdriver

`click()` doesn't find `<summary>`, `<label>`, or elements inside `<a>`

Offen
#18 4 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
PHP
Sterne
39
Forks
25
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

The HTML5 element `` is missing from the list of clickable elements at [`WebDriver::_findClickable()`](https://github.com/Codeception/module-webdriver/blob/master/src/Codeception/Module/WebDriver.php#L1047)

I tried to add it there just like the others: `".//summary[normalize-space(.)=$locator]",` - but this doesn't really fix it, since there are many elements allowed inside ``: https://html.spec.whatwg.org/#the-summary-element

I think this needs to be refactored, since (from looking at the code) elements inside `` are also not matched, e.g. `

...
` - which is valid HTML 5: https://html.spec.whatwg.org/#the-a-element

So I guess the arguments that are thrown into `Locator::combine()` need to be replaced by functions to allow more complex matching logic.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.