Codeception / Codeception/module-webdriver

`click()` doesn't find `<summary>`, `<label>`, or elements inside `<a>`

Open
#18 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
39
Forks
25
PR merge metrics
No merged PRs in 30d

Description

The HTML5 element `` is missing from the list of clickable elements at [`WebDriver::_findClickable()`](https://github.com/Codeception/module-webdriver/blob/master/src/Codeception/Module/WebDriver.php#L1047)

I tried to add it there just like the others: `".//summary[normalize-space(.)=$locator]",` - but this doesn't really fix it, since there are many elements allowed inside ``: https://html.spec.whatwg.org/#the-summary-element

I think this needs to be refactored, since (from looking at the code) elements inside `` are also not matched, e.g. `

...
` - which is valid HTML 5: https://html.spec.whatwg.org/#the-a-element

So I guess the arguments that are thrown into `Locator::combine()` need to be replaced by functions to allow more complex matching logic.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.