CodeForPhilly / CodeForPhilly/stately
Add is_valid property to assignments?
- Ngôn ngữ chính
- Python
- Star
- 22
- Fork
- 5
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
Pulled out of #35
Use case:
> Cathy and Anna are both Deputy Finance Directors. Contracts can be approved by either of them during the "Awaiting Finance Approval" state.
@mjumbewu said:
> I'm considering adding an is_valid field to Assignment instances. So, in the case where Cathy and Anna are both Deputy Finance Directors, when one acts on their assignment, the other's assignment would get is_valid set to False -- perhaps explicitly in the handler, perhaps automatically as a consequence of the case transitioning out of the assigned state with no action taken on the assignment. Probably the latter.
>
> Does that seem reasonable? If the case transitions to another state, then all incomplete assignments are simply marked as invalid?
@timwis replied:
> maybe I'm misunderstanding, but I'm not sure that's necessary. If the /cases/awaiting/ endpoint queries cases that (a) are assigned to you, (b) you haven't acted on yet, and (c) the case is currently in the state you're assigned to -- it should handle both scenarios described above, no?
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Hướng nghiên cứu
Start with issue #35 and the /cases/awaiting/ endpoint described in the thread, then trace how Assignment state changes when a case leaves its assigned state. Resolve whether incomplete assignments need an is_valid property and document the chosen behavior; done means the two-assignee scenario has an agreed, observable outcome.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- python
- Lĩnh vực
- backend
- Loại issue
- Tính năng
- Độ khó
- 5/5
- Thời gian dự kiến
- Hơn một tuần
- Mức độ hoạt động
- Đình trệ
- Độ rõ ràng
- Cần làm rõ
- Mức phù hợp với người mới
- 25/100