CodeForPhilly / CodeForPhilly/stately

Add is_valid property to assignments?

未关闭
#52 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
discussion
主要语言
Python
星标
22
派生
5
PR 合并指标
30 天内没有已合并 PR

描述

Pulled out of #35

Use case:

> Cathy and Anna are both Deputy Finance Directors. Contracts can be approved by either of them during the "Awaiting Finance Approval" state.

@mjumbewu said:

> I'm considering adding an is_valid field to Assignment instances. So, in the case where Cathy and Anna are both Deputy Finance Directors, when one acts on their assignment, the other's assignment would get is_valid set to False -- perhaps explicitly in the handler, perhaps automatically as a consequence of the case transitioning out of the assigned state with no action taken on the assignment. Probably the latter.
>
> Does that seem reasonable? If the case transitions to another state, then all incomplete assignments are simply marked as invalid?

@timwis replied:

> maybe I'm misunderstanding, but I'm not sure that's necessary. If the /cases/awaiting/ endpoint queries cases that (a) are assigned to you, (b) you haven't acted on yet, and (c) the case is currently in the state you're assigned to -- it should handle both scenarios described above, no?

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start with issue #35 and the /cases/awaiting/ endpoint described in the thread, then trace how Assignment state changes when a case leaves its assigned state. Resolve whether incomplete assignments need an is_valid property and document the chosen behavior; done means the two-assignee scenario has an agreed, observable outcome.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
backend
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。