CCExtractor / CCExtractor/ccsync

bug: hotkeysEnabled state is set but never checked before executing hotkeys

オープン
#425 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement frontend
主要言語
TypeScript
スター
37
フォーク
76
平均マージ
3日 7時間
マージ済み PR(30日)
2

説明

**Describe the bug**
The `hotkeysEnabled` state in the tasks component is set via mouse enter/leave handlers but is never actually checked before executing hotkey actions, it means hotkeys work globally on the page regardless of mouse position.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to `http://localhost:5173/home`
2. Hover your mouse outside the task table
3. Press f key
4. See that the search input still gets focused
5. Press r key
6. See that sync still triggers

**Expected behavior**
- Hotkeys (f, p, ArrowUp, ArrowDown, Enter, etc.) should only work when the mouse is hovering over the task table, when mouse leaves the task table, hotkeys should be disabled

**Root cause**
- `hotkeysEnabled` state is defined and set via **onMouseEnter/onMouseLeave** but the manual `useEffect` keyboard handler and all useHotkeys calls does not check `hotkeysEnabled` before executing

**Desktop (please complete the following information):**
- OS: macOS
- Browser: Chrome
- Version: Latest

**video:**

https://github.com/user-attachments/assets/6eeacafc-9ed0-421a-9f52-3985c2f6711a

- [x] I want to work on this issue.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。