CCExtractor / CCExtractor/ccsync

bug: hotkeysEnabled state is set but never checked before executing hotkeys

Aberta
#425 0 comentários 0 reações 0 responsáveis Ver no GitHub
enhancement frontend
Linguagem predominante
TypeScript
Estrelas
37
Forks
76
Merge médio
3d 7h
PRs com merge (30d)
2

Descrição

**Describe the bug**
The `hotkeysEnabled` state in the tasks component is set via mouse enter/leave handlers but is never actually checked before executing hotkey actions, it means hotkeys work globally on the page regardless of mouse position.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to `http://localhost:5173/home`
2. Hover your mouse outside the task table
3. Press f key
4. See that the search input still gets focused
5. Press r key
6. See that sync still triggers

**Expected behavior**
- Hotkeys (f, p, ArrowUp, ArrowDown, Enter, etc.) should only work when the mouse is hovering over the task table, when mouse leaves the task table, hotkeys should be disabled

**Root cause**
- `hotkeysEnabled` state is defined and set via **onMouseEnter/onMouseLeave** but the manual `useEffect` keyboard handler and all useHotkeys calls does not check `hotkeysEnabled` before executing

**Desktop (please complete the following information):**
- OS: macOS
- Browser: Chrome
- Version: Latest

**video:**

https://github.com/user-attachments/assets/6eeacafc-9ed0-421a-9f52-3985c2f6711a

- [x] I want to work on this issue.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.