BlockchainCommons / BlockchainCommons/bc-lifehash-python
Modes not working -> Extend unit test
- 主要语言
- Python
- 星标
- 1
- 派生
- 1
- PR 合并指标
- 30 天内没有已合并 PR
描述
Hy dear LifeHash developers,
nice project. Yet, using you code with python 3.13 sadly made some issues.
It seems you are expecting to have the "+" operator to be defined on a hashlib.sha256 as well as hashlib.sha256 on another hashlib.sha256 ( sha256(sha256(bytes)) ).
lifehash/lifehash.py line 1024 thus fails. I think you just need to add a few .digest() here and there.
I get why you did not see that. I strongly suggest to extend you unit tests to test *all* modes for you LifeHash. Currently you only test version2.
贡献指南
调研方向
从 lifehash/lifehash.py 第 1024 行开始,检查在 Python 3.13 下如何组合 hashlib.sha256 值。查看现有的单元测试,这些测试目前只覆盖 version2,然后运行它们,同时检查其他 LifeHash 模式。完成的标准是处理导致失败的哈希路径,并让测试覆盖所有模式。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- testing
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100