BlockchainCommons / BlockchainCommons/bc-lifehash-python

Modes not working -> Extend unit test

Offen
#4 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
1
Forks
1
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Hy dear LifeHash developers,

nice project. Yet, using you code with python 3.13 sadly made some issues.
It seems you are expecting to have the "+" operator to be defined on a hashlib.sha256 as well as hashlib.sha256 on another hashlib.sha256 ( sha256(sha256(bytes)) ).
lifehash/lifehash.py line 1024 thus fails. I think you just need to add a few .digest() here and there.

I get why you did not see that. I strongly suggest to extend you unit tests to test *all* modes for you LifeHash. Currently you only test version2.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start at lifehash/lifehash.py line 1024 and inspect how hashlib.sha256 values are combined under Python 3.13. Review the existing unit tests, which currently cover only version2, then run them while checking the other LifeHash modes. Done means the failing hashing path is handled and tests cover all modes.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
testing
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.