BlockchainCommons / BlockchainCommons/bc-lifehash-python

Modes not working -> Extend unit test

Aperta
#4 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
1
Fork
1
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hy dear LifeHash developers,

nice project. Yet, using you code with python 3.13 sadly made some issues.
It seems you are expecting to have the "+" operator to be defined on a hashlib.sha256 as well as hashlib.sha256 on another hashlib.sha256 ( sha256(sha256(bytes)) ).
lifehash/lifehash.py line 1024 thus fails. I think you just need to add a few .digest() here and there.

I get why you did not see that. I strongly suggest to extend you unit tests to test *all* modes for you LifeHash. Currently you only test version2.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.