Azure / Azure/data-api-builder

Remove isDevelopmentMode from the ISqlMetadataProvider, SqlMetadataProvider, and CosmosSqlMetadataProvider

Aperta
#2,357 0 commenti 0 reazioni 1 assegnatario Rivendicata da @aaronburtle Vedi su GitHub
refactor
Lingua principale
C#
Stelle
1.5k
Fork
370
Merge medio
3g 22h
PR unite (30g)
9

Descrizione

We currently have a function called `IsDevelopmentMode` which is a part of the interface `ISqlMetadataProvider`. Therefore, the `SqlMetdataProvider` and the `CosmosSqlMetadataProvider` classes both implement this function.

However, all this function is doing is passing along some values that return from the `RuntimeConfigProvider`. This function is not used by the classes themselves and appears to be a case of the class handling something that is not its responsibility. We should instead favor simply using the `RuntimeConfigProvider` to determine if we are in development mode.

From the `SqlMetadataProvider`:
![image](https://github.com/user-attachments/assets/13268f83-cad4-4acd-86ec-86c666a591c8)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.