Azure / Azure/data-api-builder

Remove isDevelopmentMode from the ISqlMetadataProvider, SqlMetadataProvider, and CosmosSqlMetadataProvider

Abierto
#2,357 0 comentarios 0 reacciones 1 asignado Reclamado por @aaronburtle Ver en GitHub
refactor
Lenguaje dominante
C#
Estrellas
1.5k
Forks
372
Merge medio
3 d 22 h
PR fusionados (30 d)
9

Descripción

We currently have a function called `IsDevelopmentMode` which is a part of the interface `ISqlMetadataProvider`. Therefore, the `SqlMetdataProvider` and the `CosmosSqlMetadataProvider` classes both implement this function.

However, all this function is doing is passing along some values that return from the `RuntimeConfigProvider`. This function is not used by the classes themselves and appears to be a case of the class handling something that is not its responsibility. We should instead favor simply using the `RuntimeConfigProvider` to determine if we are in development mode.

From the `SqlMetadataProvider`:
![image](https://github.com/user-attachments/assets/13268f83-cad4-4acd-86ec-86c666a591c8)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.