Azure / Azure/data-api-builder

Remove isDevelopmentMode from the ISqlMetadataProvider, SqlMetadataProvider, and CosmosSqlMetadataProvider

Offen
#2,357 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @aaronburtle Auf GitHub ansehen
refactor
Vorherrschende Sprache
C#
Sterne
1.5k
Forks
370
Ø Merge
3 T. 22 Std.
Gemergte PRs (30 T.)
9

Beschreibung

We currently have a function called `IsDevelopmentMode` which is a part of the interface `ISqlMetadataProvider`. Therefore, the `SqlMetdataProvider` and the `CosmosSqlMetadataProvider` classes both implement this function.

However, all this function is doing is passing along some values that return from the `RuntimeConfigProvider`. This function is not used by the classes themselves and appears to be a case of the class handling something that is not its responsibility. We should instead favor simply using the `RuntimeConfigProvider` to determine if we are in development mode.

From the `SqlMetadataProvider`:
![image](https://github.com/user-attachments/assets/13268f83-cad4-4acd-86ec-86c666a591c8)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.