Azure / Azure/data-api-builder

Remove isDevelopmentMode from the ISqlMetadataProvider, SqlMetadataProvider, and CosmosSqlMetadataProvider

Open
#2,357 0 comments 0 reactions 1 assignee Claimed by @aaronburtle View on GitHub
refactor
Dominant language
C#
Stars
1.5k
Forks
370
Avg merge
3d 17h
Merged PRs (30d)
8

Description

We currently have a function called `IsDevelopmentMode` which is a part of the interface `ISqlMetadataProvider`. Therefore, the `SqlMetdataProvider` and the `CosmosSqlMetadataProvider` classes both implement this function.

However, all this function is doing is passing along some values that return from the `RuntimeConfigProvider`. This function is not used by the classes themselves and appears to be a case of the class handling something that is not its responsibility. We should instead favor simply using the `RuntimeConfigProvider` to determine if we are in development mode.

From the `SqlMetadataProvider`:
![image](https://github.com/user-attachments/assets/13268f83-cad4-4acd-86ec-86c666a591c8)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.