Azure / Azure/data-api-builder

Improve readability and extensibility in the test suite

Đang mở
#2,143 1 bình luận 0 reaction 1 người được giao Được @aaronburtle nhận Xem trên GitHub
cleanup test
Ngôn ngữ chính
C#
Star
1.5k
Fork
370
Merge trung bình
3 ngày 22 giờ
Pull request đã merge (30 ngày)
9

Mô tả

Across our test suite, we have a number of tests that have correct functionality but can be difficult to modify and have some readability issues. Things like code duplication, and hard coded values can make updates to the test time consuming.

As an example, take this test from `GraphQLPaginationTests.RequestAfterTokenOnly`

![image](https://github.com/Azure/data-api-builder/assets/93220300/1829fe7d-14b9-46a4-94cc-5d9f282ad99d)

Because of how the expected values are coded, if for example we want to update this test because we have a case where the after token is not of this form, it requires us to add another conditional that matches the new case and then has the expected value setup their. This is difficult to read, and slow to update.

As we expand our functionality we will require updates to our test suite, and improving readability and extensibility will be useful.

One candidate for code duplication is the test class used in this PR

https://github.com/Azure/data-api-builder/pull/2139

which has many spots where code is duplicated across many tests.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.