Azure / Azure/data-api-builder

Improve readability and extensibility in the test suite

Aperta
#2,143 1 commento 0 reazioni 1 assegnatario Rivendicata da @aaronburtle Vedi su GitHub
cleanup test
Lingua principale
C#
Stelle
1.5k
Fork
370
Merge medio
3g 22h
PR unite (30g)
9

Descrizione

Across our test suite, we have a number of tests that have correct functionality but can be difficult to modify and have some readability issues. Things like code duplication, and hard coded values can make updates to the test time consuming.

As an example, take this test from `GraphQLPaginationTests.RequestAfterTokenOnly`

![image](https://github.com/Azure/data-api-builder/assets/93220300/1829fe7d-14b9-46a4-94cc-5d9f282ad99d)

Because of how the expected values are coded, if for example we want to update this test because we have a case where the after token is not of this form, it requires us to add another conditional that matches the new case and then has the expected value setup their. This is difficult to read, and slow to update.

As we expand our functionality we will require updates to our test suite, and improving readability and extensibility will be useful.

One candidate for code duplication is the test class used in this PR

https://github.com/Azure/data-api-builder/pull/2139

which has many spots where code is duplicated across many tests.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.