Azure / Azure/azure-functions-durable-python

Package is accidentally shipping its tests

未关闭 适合新手
#475 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug fixed-in-v2 P3
主要语言
Python
星标
157
派生
70
平均合并
2 天 10 小时
30 天内合并 PR
2

描述

🐛 **Describe the bug**

It looks like this package is accidentally shipping its tests. This can be easily verified with:

```sh
pip show --files azure-functions-durable
```

Which shows that there are 76 tests files shipped by the package into a top-level package called `tests`. This has a few small issues:

- It bloats the package size.
- It leads to collisions with other packages that accidentally ship their tests as `tests` module (they just overwrite each other in the `site-packages` directory).
- It can lead to issues for users if it conflicts with _their_ `tests` package.

🤔 **Expected behavior**

The shipped package should not include its tests.

**Possible cause / solution**

It looks like the `setup.py` already lists `tests` under `exclude`:

https://github.com/Azure/azure-functions-durable-python/blob/b30d0a64f7b8c1042f066006af57b74976cdf9d2/setup.py#L29-L34

However if I remember correctly the pattern should be `tests/*` or `tests*` or `tests.*` or so to really affect _subfolders_. Otherwise the listing of `azure` itself would lead to the exclusion of the whole code (in this case it is most likely just about the exclusion of the top-level `__init__.py`).

☕ **Steps to reproduce**

```sh
pip install azure-functions-durable
pip show --files azure-functions-durable
```

贡献指南

打开贡献指南

调研方向

首先检查 setup.py 中的包排除配置,尤其是现有的 tests 条目。构建或安装该包,然后运行 pip show --files azure-functions-durable 以验证结果。安装后的包不再包含顶层的 tests 包或其测试文件,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
build-system
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
冷清
描述清晰度
基本清楚
新手友好度
72/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。