Azure / Azure/azure-functions-durable-python
Package is accidentally shipping its tests
- Langage dominant
- Python
- Étoiles
- 157
- Forks
- 70
- Merge moyen
- 2 j 10 h
- PR mergées (30 j)
- 2
Description
🐛 **Describe the bug**
It looks like this package is accidentally shipping its tests. This can be easily verified with:
```sh
pip show --files azure-functions-durable
```
Which shows that there are 76 tests files shipped by the package into a top-level package called `tests`. This has a few small issues:
- It bloats the package size.
- It leads to collisions with other packages that accidentally ship their tests as `tests` module (they just overwrite each other in the `site-packages` directory).
- It can lead to issues for users if it conflicts with _their_ `tests` package.
🤔 **Expected behavior**
The shipped package should not include its tests.
**Possible cause / solution**
It looks like the `setup.py` already lists `tests` under `exclude`:
https://github.com/Azure/azure-functions-durable-python/blob/b30d0a64f7b8c1042f066006af57b74976cdf9d2/setup.py#L29-L34
However if I remember correctly the pattern should be `tests/*` or `tests*` or `tests.*` or so to really affect _subfolders_. Otherwise the listing of `azure` itself would lead to the exclusion of the whole code (in this case it is most likely just about the exclusion of the top-level `__init__.py`).
☕ **Steps to reproduce**
```sh
pip install azure-functions-durable
pip show --files azure-functions-durable
```
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez par inspecter la configuration d’exclusion des paquets dans setup.py, en particulier l’entrée tests existante. Construisez ou installez le paquet, puis exécutez pip show --files azure-functions-durable pour vérifier le résultat. C’est terminé lorsque le paquet installé n’inclut plus le paquet tests de niveau supérieur ni ses fichiers de test.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- build-system
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 72/100