Azure / Azure/azure-functions-durable-python

Package is accidentally shipping its tests

Abierto Apto para principiantes
#475 1 comentario 0 reacciones 0 asignados Ver en GitHub
bug fixed-in-v2 P3
Lenguaje dominante
Python
Estrellas
157
Forks
70
Merge medio
2 d 10 h
PR fusionados (30 d)
2

Descripción

🐛 **Describe the bug**

It looks like this package is accidentally shipping its tests. This can be easily verified with:

```sh
pip show --files azure-functions-durable
```

Which shows that there are 76 tests files shipped by the package into a top-level package called `tests`. This has a few small issues:

- It bloats the package size.
- It leads to collisions with other packages that accidentally ship their tests as `tests` module (they just overwrite each other in the `site-packages` directory).
- It can lead to issues for users if it conflicts with _their_ `tests` package.

🤔 **Expected behavior**

The shipped package should not include its tests.

**Possible cause / solution**

It looks like the `setup.py` already lists `tests` under `exclude`:

https://github.com/Azure/azure-functions-durable-python/blob/b30d0a64f7b8c1042f066006af57b74976cdf9d2/setup.py#L29-L34

However if I remember correctly the pattern should be `tests/*` or `tests*` or `tests.*` or so to really affect _subfolders_. Otherwise the listing of `azure` itself would lead to the exclusion of the whole code (in this case it is most likely just about the exclusion of the top-level `__init__.py`).

☕ **Steps to reproduce**

```sh
pip install azure-functions-durable
pip show --files azure-functions-durable
```

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza inspeccionando la configuración de exclusión de paquetes en setup.py, especialmente la entrada tests existente. Compila o instala el paquete y ejecuta pip show --files azure-functions-durable para verificar el resultado. La tarea se considera completada cuando el paquete instalado ya no incluye el paquete tests de nivel superior ni sus archivos de prueba.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
build-system
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
72/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.