Azure / Azure/AppConfiguration-JavaScriptProvider

"application/json" content type is not handled in KeyVault references

未關閉
#78 11 則留言 0 個 reaction 已指派 1 人 已被 @Eskibear 認領 在 GitHub 檢視
enhancement
主要語言
TypeScript
星號
18
分支
13
平均合併
1 天 5 小時
30 天內合併 PR
4

描述

Internally AzureKeyVaultKeyValueAdapter doesn't handle ContentType property of secret value and returns naked value.

So we have dual behavior when same JSON setting stored directly or using keyvault reference with application/json content type returned as object or string.

I think problem seats at this peace of AzureKeyVaultKeyValueAdapter code
` if (client) {
// TODO: what if error occurs when reading a key vault value? Now it breaks the whole load.
const secret = await client.getSecret(secretName, { version });
return [setting.key, secret.value]; // here it returns raw value without considering secret.properties.contentType value
}
`

Thank you,

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。