Azure / Azure/AppConfiguration-JavaScriptProvider

"application/json" content type is not handled in KeyVault references

未关闭
#78 11 条评论 0 个 reaction 已指派 1 人 已被 @Eskibear 认领 在 GitHub 查看
enhancement
主要语言
TypeScript
星标
18
派生
13
平均合并
1 天 5 小时
30 天内合并 PR
4

描述

Internally AzureKeyVaultKeyValueAdapter doesn't handle ContentType property of secret value and returns naked value.

So we have dual behavior when same JSON setting stored directly or using keyvault reference with application/json content type returned as object or string.

I think problem seats at this peace of AzureKeyVaultKeyValueAdapter code
` if (client) {
// TODO: what if error occurs when reading a key vault value? Now it breaks the whole load.
const secret = await client.getSecret(secretName, { version });
return [setting.key, secret.value]; // here it returns raw value without considering secret.properties.contentType value
}
`

Thank you,

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。