Azure / Azure/AppConfiguration-JavaScriptProvider

"application/json" content type is not handled in KeyVault references

Abierto
#78 11 comentarios 0 reacciones 1 asignado Reclamado por @Eskibear Ver en GitHub
enhancement
Lenguaje dominante
TypeScript
Estrellas
18
Forks
13
Merge medio
1 d 5 h
PR fusionados (30 d)
4

Descripción

Internally AzureKeyVaultKeyValueAdapter doesn't handle ContentType property of secret value and returns naked value.

So we have dual behavior when same JSON setting stored directly or using keyvault reference with application/json content type returned as object or string.

I think problem seats at this peace of AzureKeyVaultKeyValueAdapter code
` if (client) {
// TODO: what if error occurs when reading a key vault value? Now it breaks the whole load.
const secret = await client.getSecret(secretName, { version });
return [setting.key, secret.value]; // here it returns raw value without considering secret.properties.contentType value
}
`

Thank you,

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.