Automattic / Automattic/VIP-Coding-Standards

Adding WordPress-VIP-Go ruleset suppresses many warnings

未关闭
#441 13 条评论 0 个 reaction 已指派 1 人 已指派给 @rebeccahum 在 GitHub 查看
主要语言
PHP
星标
261
派生
44
平均合并
19 分钟
30 天内合并 PR
1

描述

## Bug Description

Adding the `WordPress-VIP-Go` ruleset suppresses many warning from `WordPress-Core`, including `StrictComparisons.LooseComparison`.

Sample file (test.php)
```php


```

Output:
```
$ vendor/bin/phpcs test.php
W 1 / 1 (100%)
```

Example ruleset:
```

```

Output:
```
$ vendor/bin/phpcs test.php
W 1 / 1 (100%)

FILE: test.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
2 | WARNING | Found: ==. Use strict comparisons (=== or !==).
| | (WordPress.PHP.StrictComparisons.LooseComparison)
-----------------------------------------------------------------------------------------------------------------

Time: 268ms; Memory: 8MB
```

## Environment

| Question | Answer
| ------------------------| -------
| PHP version | 7.3.3
| PHP_CodeSniffer version | 3.4.2
| VIPCS version | 2.0.0

## Additional Context (optional)

The problem seems to be this commit: https://github.com/Automattic/VIP-Coding-Standards/commit/b8c5b767e96d32bbfa096a2d9e07f7db382737d9

Setting `` to 3 results in no output. Setting it to 5 results in the expected output.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。