Automattic / Automattic/VIP-Coding-Standards

Adding WordPress-VIP-Go ruleset suppresses many warnings

Abierto
#441 13 comentarios 0 reacciones 1 asignado Asignado a @rebeccahum Ver en GitHub
Lenguaje dominante
PHP
Estrellas
261
Forks
44
Merge medio
19 min
PR fusionados (30 d)
1

Descripción

## Bug Description

Adding the `WordPress-VIP-Go` ruleset suppresses many warning from `WordPress-Core`, including `StrictComparisons.LooseComparison`.

Sample file (test.php)
```php


```

Output:
```
$ vendor/bin/phpcs test.php
W 1 / 1 (100%)
```

Example ruleset:
```

```

Output:
```
$ vendor/bin/phpcs test.php
W 1 / 1 (100%)

FILE: test.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
2 | WARNING | Found: ==. Use strict comparisons (=== or !==).
| | (WordPress.PHP.StrictComparisons.LooseComparison)
-----------------------------------------------------------------------------------------------------------------

Time: 268ms; Memory: 8MB
```

## Environment

| Question | Answer
| ------------------------| -------
| PHP version | 7.3.3
| PHP_CodeSniffer version | 3.4.2
| VIPCS version | 2.0.0

## Additional Context (optional)

The problem seems to be this commit: https://github.com/Automattic/VIP-Coding-Standards/commit/b8c5b767e96d32bbfa096a2d9e07f7db382737d9

Setting `` to 3 results in no output. Setting it to 5 results in the expected output.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.