Automattic / Automattic/VIP-Coding-Standards

Adding WordPress-VIP-Go ruleset suppresses many warnings

Offen
#441 13 Kommentare 0 Reaktionen 1 zugewiesene Person Zugewiesen an @rebeccahum Auf GitHub ansehen
Vorherrschende Sprache
PHP
Sterne
261
Forks
44
Ø Merge
19 Min.
Gemergte PRs (30 T.)
1

Beschreibung

## Bug Description

Adding the `WordPress-VIP-Go` ruleset suppresses many warning from `WordPress-Core`, including `StrictComparisons.LooseComparison`.

Sample file (test.php)
```php


```

Output:
```
$ vendor/bin/phpcs test.php
W 1 / 1 (100%)
```

Example ruleset:
```

```

Output:
```
$ vendor/bin/phpcs test.php
W 1 / 1 (100%)

FILE: test.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
2 | WARNING | Found: ==. Use strict comparisons (=== or !==).
| | (WordPress.PHP.StrictComparisons.LooseComparison)
-----------------------------------------------------------------------------------------------------------------

Time: 268ms; Memory: 8MB
```

## Environment

| Question | Answer
| ------------------------| -------
| PHP version | 7.3.3
| PHP_CodeSniffer version | 3.4.2
| VIPCS version | 2.0.0

## Additional Context (optional)

The problem seems to be this commit: https://github.com/Automattic/VIP-Coding-Standards/commit/b8c5b767e96d32bbfa096a2d9e07f7db382737d9

Setting `` to 3 results in no output. Setting it to 5 results in the expected output.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.