AlphaWallet / AlphaWallet/alpha-wallet-android

If Transaction is a constructor treat specially in ActionSheet

Ouverte
#2,810 0 commentaires 0 réactions 1 personne assignée Réclamée par @justindg Voir sur GitHub
Langage dominant
Java
Étoiles
646
Forks
579
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

If Transaction is a constructor:

- Display transaction as 'Constructor' in ActionSheet
- Display Transaction Deployment Address (*)

(*) See `class EthUtils` -> `calculateContractAddress(String account, long nonce)`

It might make sense to move this code into the app's ```class Utils```, and reference it from the test from here (I think you can do that). You might have to get the nonce value, or pass it in via the Web3Transaction. It's fetched when we do the transaction gas estimate.

It would be really good if that contract address has a 'copy to clipboard' on it too. The reason is I want to provide people with an easy way to find what address the contract will deploy to before they send.

To test, use my test page here:

https://jamessmartcell.github.io/

You can mint NFT contracts via WalletConnect. Note that you can't (easily!) get information about the contract itself, I guess unless it's a totally standard ERC721/ERC20.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.