AlphaWallet / AlphaWallet/alpha-wallet-android

If Transaction is a constructor treat specially in ActionSheet

Offen
#2,810 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @justindg Auf GitHub ansehen
Vorherrschende Sprache
Java
Sterne
646
Forks
579
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

If Transaction is a constructor:

- Display transaction as 'Constructor' in ActionSheet
- Display Transaction Deployment Address (*)

(*) See `class EthUtils` -> `calculateContractAddress(String account, long nonce)`

It might make sense to move this code into the app's ```class Utils```, and reference it from the test from here (I think you can do that). You might have to get the nonce value, or pass it in via the Web3Transaction. It's fetched when we do the transaction gas estimate.

It would be really good if that contract address has a 'copy to clipboard' on it too. The reason is I want to provide people with an easy way to find what address the contract will deploy to before they send.

To test, use my test page here:

https://jamessmartcell.github.io/

You can mint NFT contracts via WalletConnect. Note that you can't (easily!) get information about the contract itself, I guess unless it's a totally standard ERC721/ERC20.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.