AlphaWallet / AlphaWallet/alpha-wallet-android

If Transaction is a constructor treat specially in ActionSheet

Abierto
#2,810 0 comentarios 0 reacciones 1 asignado Reclamado por @justindg Ver en GitHub
Lenguaje dominante
Java
Estrellas
646
Forks
579
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

If Transaction is a constructor:

- Display transaction as 'Constructor' in ActionSheet
- Display Transaction Deployment Address (*)

(*) See `class EthUtils` -> `calculateContractAddress(String account, long nonce)`

It might make sense to move this code into the app's ```class Utils```, and reference it from the test from here (I think you can do that). You might have to get the nonce value, or pass it in via the Web3Transaction. It's fetched when we do the transaction gas estimate.

It would be really good if that contract address has a 'copy to clipboard' on it too. The reason is I want to provide people with an easy way to find what address the contract will deploy to before they send.

To test, use my test page here:

https://jamessmartcell.github.io/

You can mint NFT contracts via WalletConnect. Note that you can't (easily!) get information about the contract itself, I guess unless it's a totally standard ERC721/ERC20.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.