AlphaWallet / AlphaWallet/alpha-wallet-android

Refactor WalletConnect OKHttp client usage

未关闭
#2,210 1 条评论 0 个 reaction 已指派 1 人 已被 @asif-finimble 认领 在 GitHub 查看
主要语言
Java
星标
646
派生
579
PR 合并指标
30 天内没有已合并 PR

描述

Refactor WalletConnectActivity, WCClient and WalletConnectService to remove the OKHttp client from WCClient and move ownership of all WC comms into WalletConnectService.

Currently, because the OKHttp client is created in WalletConnectActivity, and kept within each WCClient object, and each OKHttp client connect contains a link to the WalletConnectActivity context, the context is leaked when WalletConnectActivity is destroyed.

The OKHttp client should be constructed in WaletConnectService, using the service context.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。