AlphaWallet / AlphaWallet/alpha-wallet-android
Refactor WalletConnect OKHttp client usage
Open
- Dominant language
- Java
- Stars
- 646
- Forks
- 579
- PR merge metrics
- No merged PRs in 30d
Description
Refactor WalletConnectActivity, WCClient and WalletConnectService to remove the OKHttp client from WCClient and move ownership of all WC comms into WalletConnectService.
Currently, because the OKHttp client is created in WalletConnectActivity, and kept within each WCClient object, and each OKHttp client connect contains a link to the WalletConnectActivity context, the context is leaked when WalletConnectActivity is destroyed.
The OKHttp client should be constructed in WaletConnectService, using the service context.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.