AlphaWallet / AlphaWallet/alpha-wallet-android

Refactor WalletConnect OKHttp client usage

Aperta
#2,210 1 commento 0 reazioni 1 assegnatario Rivendicata da @asif-finimble Vedi su GitHub
Lingua principale
Java
Stelle
646
Fork
579
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Refactor WalletConnectActivity, WCClient and WalletConnectService to remove the OKHttp client from WCClient and move ownership of all WC comms into WalletConnectService.

Currently, because the OKHttp client is created in WalletConnectActivity, and kept within each WCClient object, and each OKHttp client connect contains a link to the WalletConnectActivity context, the context is leaked when WalletConnectActivity is destroyed.

The OKHttp client should be constructed in WaletConnectService, using the service context.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.