AlmaLinux / AlmaLinux/build-system

Review routes and ensure that there are no more navigation warnings around calling next more than once

Aberta
#435 0 comentários 0 reações 0 responsáveis Ver no GitHub
good first issue ui
Linguagem predominante
Sem dados de linguagem
Estrelas
32
Forks
11
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

As unveiled in the [following issue](https://github.com/AlmaLinux/build-system/issues/430) and resolved in [this PR](https://github.com/AlmaLinux/albs-frontend/pull/588), there might be some navigation in other places due to use of calling `next()` as part of promise handling in the routing process.

We should review albs-frontend's [routes.js](https://github.com/AlmaLinux/albs-frontend/blob/master/src/router/routes.js) and ensure that:
* We stop calling next, and pass it as a callback in the promise resolution process
* Several store/state dispatchers in `beforeEnter` should be wrapped into a Promise.all

After the update, we need to check that the navigation works as expected and that there are no more navigation warnings around.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.