AlmaLinux / AlmaLinux/build-system

Review routes and ensure that there are no more navigation warnings around calling next more than once

Abierto
#435 0 comentarios 0 reacciones 0 asignados Ver en GitHub
good first issue ui
Lenguaje dominante
Sin datos de lenguaje
Estrellas
32
Forks
11
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

As unveiled in the [following issue](https://github.com/AlmaLinux/build-system/issues/430) and resolved in [this PR](https://github.com/AlmaLinux/albs-frontend/pull/588), there might be some navigation in other places due to use of calling `next()` as part of promise handling in the routing process.

We should review albs-frontend's [routes.js](https://github.com/AlmaLinux/albs-frontend/blob/master/src/router/routes.js) and ensure that:
* We stop calling next, and pass it as a callback in the promise resolution process
* Several store/state dispatchers in `beforeEnter` should be wrapped into a Promise.all

After the update, we need to check that the navigation works as expected and that there are no more navigation warnings around.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.