AlmaLinux / AlmaLinux/build-system

Review routes and ensure that there are no more navigation warnings around calling next more than once

Aperta
#435 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
good first issue ui
Lingua principale
Nessun dato sulla lingua
Stelle
32
Fork
11
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

As unveiled in the [following issue](https://github.com/AlmaLinux/build-system/issues/430) and resolved in [this PR](https://github.com/AlmaLinux/albs-frontend/pull/588), there might be some navigation in other places due to use of calling `next()` as part of promise handling in the routing process.

We should review albs-frontend's [routes.js](https://github.com/AlmaLinux/albs-frontend/blob/master/src/router/routes.js) and ensure that:
* We stop calling next, and pass it as a callback in the promise resolution process
* Several store/state dispatchers in `beforeEnter` should be wrapped into a Promise.all

After the update, we need to check that the navigation works as expected and that there are no more navigation warnings around.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.