AlmaLinux / AlmaLinux/build-system

Review routes and ensure that there are no more navigation warnings around calling next more than once

Open
#435 0 comments 0 reactions 0 assignees View on GitHub
good first issue ui
Dominant language
No language data
Stars
32
Forks
11
PR merge metrics
No merged PRs in 30d

Description

As unveiled in the [following issue](https://github.com/AlmaLinux/build-system/issues/430) and resolved in [this PR](https://github.com/AlmaLinux/albs-frontend/pull/588), there might be some navigation in other places due to use of calling `next()` as part of promise handling in the routing process.

We should review albs-frontend's [routes.js](https://github.com/AlmaLinux/albs-frontend/blob/master/src/router/routes.js) and ensure that:
* We stop calling next, and pass it as a callback in the promise resolution process
* Several store/state dispatchers in `beforeEnter` should be wrapped into a Promise.all

After the update, we need to check that the navigation works as expected and that there are no more navigation warnings around.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.