AllenNeuralDynamics / AllenNeuralDynamics/ficus

Remove db-structure-related contents of settings.json

未關閉
#38 0 則留言 0 個 reaction 已指派 1 人 已被 @jessy-liao 認領 在 GitHub 檢視
主要語言
Python
星號
1
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

Ficus **settings.json** file, currently required for each PC that wants to communicate with ficus, require a `scope` field.

Here's an [example settings.json](https://github.com/AllenNeuralDynamics/prototome-instrument/blob/dev/examples/ficus_setup.json).

The contents of the `scope` field are basically validating the internal structure of the connected database. If that's indeed the case, let's not do this at this level and instead do it inside of the ficus client library (probably with a pydantic model). Doing it at this level violates separation of concerns where each computer that wants to interact with the database needs to know something about its structure in order to interact with it rather than delegating that work to the ficus client library. It also makes the file harder to maintain since individual fields will need to change everywhere if the folder structure ever changes.

That's all to say, let's remove this `scope` field from **settings.json** if possible.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。