AllenNeuralDynamics / AllenNeuralDynamics/ficus

Remove db-structure-related contents of settings.json

未关闭
#38 0 条评论 0 个 reaction 已指派 1 人 已被 @jessy-liao 认领 在 GitHub 查看
主要语言
Python
星标
1
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

Ficus **settings.json** file, currently required for each PC that wants to communicate with ficus, require a `scope` field.

Here's an [example settings.json](https://github.com/AllenNeuralDynamics/prototome-instrument/blob/dev/examples/ficus_setup.json).

The contents of the `scope` field are basically validating the internal structure of the connected database. If that's indeed the case, let's not do this at this level and instead do it inside of the ficus client library (probably with a pydantic model). Doing it at this level violates separation of concerns where each computer that wants to interact with the database needs to know something about its structure in order to interact with it rather than delegating that work to the ficus client library. It also makes the file harder to maintain since individual fields will need to change everywhere if the folder structure ever changes.

That's all to say, let's remove this `scope` field from **settings.json** if possible.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。